Calling Developers!
We are reenergizing our code contribution process! Learn More

Planned replacement of tslint with eslint

U012PCVT2DB
U012PCVT2DB Posts: 66 πŸ§‘πŸ»β€πŸš€ - Cadet
edited June 2023 in Spryker Development

Hello spryker-team,

i have noticed, that spryker will replace tslint with eslint in the next version (CC-25963 Replaced tslint with eslint for YVES. ).
Upon reviewing it for our current development and future updates, i saw the changes in package.json.

I don't think this is an optimal solution, since this only binds the linting to the PYZ-namespace and no custom namespace.
Another suggestion would be to rename the yves:eslint function to just "yves:lint" so any future linter-updates won't break pipelines and functionalities.

Can you share some insight on why you chose to bind this only to PYZ or has this maybe slipped through your internal review?

Comments

  • Yuriy Gerton
    Yuriy Gerton Front End Technical Lead Sprykee Posts: 49 πŸ§‘πŸ»β€πŸš€ - Cadet

    Hello Sven.
    Thank you for good point 🀝
    It’s named according to the previous version.
    We’ll rename it to the variant without the linter name.

  • Yuriy Gerton
    Yuriy Gerton Front End Technical Lead Sprykee Posts: 49 πŸ§‘πŸ»β€πŸš€ - Cadet
  • U012PCVT2DB
    U012PCVT2DB Posts: 66 πŸ§‘πŸ»β€πŸš€ - Cadet

    My only concern (now) is that is only checking the pyz-namespace and no additional one 😞

    before it checked every namespace.

  • Yuriy Gerton
    Yuriy Gerton Front End Technical Lead Sprykee Posts: 49 πŸ§‘πŸ»β€πŸš€ - Cadet

    We expect that the linter must only check project-level YVES components.
    According to the folder structure.
    Each project can customize the paths according to its requirements.