Calling Developers!
We are reenergizing our code contribution process! Learn More

What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

does anyone know any ETA on making spryker-eco/adyen compatible with latest spryker-shop/suite ?

Options
UK5DS29L2
UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet

does anyone know any ETA on making spryker-eco/adyen compatible with latest spryker-shop/suite ?

Comments

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    Isn't it compatible? 🤔

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    Options

    no, hence the question

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    Options

    my guess it's just because it has specific versions listed in adyen extension composer.json

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    edited November 2019
    Options

    otherwise it probably would be

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    I'll clarify.

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    So there is a draft PR like a month old where everything has been updated.
    Now I'm waiting for an answer from our Product team regarding when?.

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    Current plan is to fix all eco-integrations together with next release which is going to happen around December-January.

    Is it a blocker for you atm?

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    Options

    yes, because you have fixed some cms stuff in new suite that didn't work before update, but no in adyen so packages are not compatible

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    Options

    @valerii.trots would it be possible for you to point me at the branch so we can check if it works for us and proceed?

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    edited November 2019
    Options
  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    edited November 2019
    Options

    Because there is an open PR https://github.com/spryker-eco/adyen/pull/20

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    Options

    yup, this open PR looks like what we're after I'll check this soon

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    Options

    so just to keep you updated, even after switching to adyen branch from PR, we get:

    Exception: Value mismatch for "Item.stock" tranfer property. Value1: "int"; Value2: "decimal". To fix this, search for 'property name="stock"' in the code base and fix the wrong one. 
    

    which seems to be "fixed" in "spryker/availability-offer-connector": "^4.0.0", but this is not yet in shop suite

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    Ok, so you use really latest suite with decimal stock released one or two days ago it seems.

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    Anyway, I forwarded the info that this is a blocker for you now.

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    Options

    well, can't really force people to NOT use composer update to check for updates 🙂

  • UK5DS29L2
    UK5DS29L2 Posts: 546 🧑🏻‍🚀 - Cadet
    Options

    if semver says it's compatible, it should be compatible

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    Yep, true.