Calling Developers!
We are reenergizing our code contribution process! Learn More

What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

About

Options
UM4BZSK7T
UM4BZSK7T Posts: 174 🧑🏻‍🚀 - Cadet

About https://github.com/spryker/oauth-permission/blob/c7760972b6cc3019081f87f9c42c2c20b[…]lient/OauthPermission/OauthPermission/OauthPermissionReader.php In our case we got a header that didn't contain any spaces and we get an exception. In our opinion it would be better in this case to get always an empty PermissionCollectionTransfer and no exception. And this method should be refactored in regards of line 54 because the method is calle extractToken and type isn't used at all.

Comments

  • Sounds right.
    Do you want to make a PR here with suggested changes?
    We can fast track those then.

  • UM4BZSK7T
    UM4BZSK7T Posts: 174 🧑🏻‍🚀 - Cadet
    Options

    😍 You would allow me a PR? That would be amazing!