Calling Developers!
We are reenergizing our code contribution process! Learn More

What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

Hi all! We are updating our B2B codebase to the latest version 202212.0 and see, that a lot of metho

Options
U01DH3E31C1
U01DH3E31C1 Posts: 23 🧑🏻‍🚀 - Cadet

Hi all!
We are updating our B2B codebase to the latest version 202212.0 and see, that a lot of methods, constants, database fields, transfer firelds and more are renamed to "Pyz". For example

$this->getFactory()
    ->createPyzCheckoutFormFactory()
...

Can you please share some insights on why you did this? It seems that it is not a matter of code that lives in the Pyz namespace only, right? Should not the namespace "Pyz" make things clear enough?
Thanks in advance

Comments

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    Options

    it doesn't make sense to me what was done.... just complicates things....
    But u are right.. now u have a lot of changes in update/upgrade...
    We update/upgrade always from suite and take a look always to B2B codebase..

  • Denis Turkov
    Denis Turkov VP Architecture Sprykee Posts: 40 🏛 - Council (mod)
    Options

    @UP5GJTY58 could you please have a look?

  • Denis Turkov
    Denis Turkov VP Architecture Sprykee Posts: 40 🏛 - Council (mod)
    Options

    Thanks @U01DH3E31C1@UL65CH0MC for your feedback! 😉 We will get to it asap.

  • Karoly Gerner
    Karoly Gerner Application Architect Sprykee Posts: 5 🧑🏻‍🚀 - Cadet
    Options

    Hi @U01DH3E31C1 & @UL65CH0MC,

    Thank you for raising the issue. The majority of these changes were introduced as part of 202204 release in order to increase upgradeability (and so to decrease costs on the long-term for the projects).

    However it is clear now, that some enhancements or changes to this concept, that took place in the previous release, are not necessary. We will take time to review all relevant feedbacks, adjust the strategy with the responsible team and will provide you an update next week.

    Additional details on the reasoning of this change you can find here:
    https://docs.spryker.com/docs/scos/dev/guidelines/keeping-a-project-upgradable/keeping-a-project-upgradable.html

  • Ahmed Sabaa
    Ahmed Sabaa Senior Application Architect @Spryker Sprykee Posts: 54 🧑🏻‍🚀 - Cadet
    Options

    Good morning @U01DH3E31C1, @UL65CH0MC

    We will provide more insights to the reasoning why we did this in detail, but I do wish we can get a bit more understanding and detail into your complaint. Can you please explain why this complicates things?

  • U01DH3E31C1
    U01DH3E31C1 Posts: 23 🧑🏻‍🚀 - Cadet
    Options

    Good Morning @ULL9CA6CB!
    Yes, it is a lot of effort for us to follow these Pyz changes, but for me personally it is not primarily a complaint. It's more that we want to understand it and maybe change the way we understand the code. Maybe we are misssing some tools to track these changes or need to adapt our workflows?
    It's one thing to change functions and variable names, but a different thing to change interfaces, database and transfer fields.

  • Ahmed Sabaa
    Ahmed Sabaa Senior Application Architect @Spryker Sprykee Posts: 54 🧑🏻‍🚀 - Cadet
    Options

    Hi @U01DH3E31C1 @UL65CH0MC this was an attempt to avoid conflicts that could be done on project level, the current BC promise of Spryker does not include anything in project code. This is no longer our upgradability tooling direction so we’ll fix those problems on our side of demoshops..now the question is:

    Is this a direct request from you guys as Spryker users or is it a nice-to-have? Because this will affect its priority