Calling Developers!
We are reenergizing our code contribution process! Learn More

spryker/product-image-storage 1.15.0 causing exceptions

U03GRNCV1B4
U03GRNCV1B4 Posts: 2 🧑🏻‍🚀 - Cadet
edited June 2023 in Spryker Development

Hello,

4 days ago this commit was introduced with a new tag 1.15.0 in spryker/product-image-storage .
https://github.com/spryker/product-image-storage/commit/ab4e157b84b07a2006d17cfbc3b0145e230b6e62#diff-126f52f35440e9105c3[…]35f7fc5a4e68702d9e719b81

The bridge now has an array as fixed type, however, the underlying storage-client has multiple return types null|array|....
This causes exceptions whenever the underlying storage-client return something else than array.

I did not know where else to contact than here, as the issue board on github is deactivated.

Comments

  • fsmeier
    fsmeier Senior Software Engineer & Developer Enablement Advocate Sprykee Posts: 1,005 ⚖️ - Guardians (admin)

    Hey, good catch! I reported it internally. If you want to push priority you can do this by creating a bug issue through either the partner portal (if you work for an official partner agency) or the customer portal (if you work for a customer right now). There is normally a business person on project level who has access to it.

    If there was a ticket submitted please let me know so i can let it be linked to the one i reported 🙂

  • U03GRNCV1B4
    U03GRNCV1B4 Posts: 2 🧑🏻‍🚀 - Cadet

    There is no urgency as 1.14.0 is also available and working well so far.

    We just pinned that version.

    Ty for reaction ❤

  • U02MH0VAFFT
    U02MH0VAFFT Posts: 3 🧑🏻‍🚀 - Cadet

    Hey everyone, we just updated spryker/product-image-storage to version 1.15.0 and with this change https://github.com/spryker/product-image-storage/compare/1.14.0...1.15.0#diff-69f3fb1747c034c9e847e1bc861258e9dcdd9581a0a12e76ab8f943fa744a488R17 it broke our implementation due to this error ERROR - Declaration of Spryker\Client\Storage\StorageClientInterface::get($key) must be compatible with Spryker\Client\ProductImageStorage\Dependency\Client\ProductImageStorageToStorageInterface::get($key): array this happen because we have a Pyz override of Spryker\Client\Storage\StorageClientInterface which is extending ProductImageStorageToStorageInterface for us to be able to have access to \Spryker\Client\Storage\StorageClientInterface::getMulti() in the places where this bridge is used. Since the get() method return type is now different in the bridge it gives this error. Just FYI in case this needs to be changed on your side

  • U02MH0VAFFT
    U02MH0VAFFT Posts: 3 🧑🏻‍🚀 - Cadet
    edited June 2023

    And I looked a bit deeper and it seems that the underlying StorageClient could potentially return null which would then break due to the type not being an array

  • fsmeier
    fsmeier Senior Software Engineer & Developer Enablement Advocate Sprykee Posts: 1,005 ⚖️ - Guardians (admin)
    edited June 2023

    The more “official” reports through the dedicated support channels the higher prio 🙂 - Here in slack is no official support. Here we help each other - from dev to dev 💪

  • U02MH0VAFFT
    U02MH0VAFFT Posts: 3 🧑🏻‍🚀 - Cadet
    edited June 2023

    Makes sense, thank you for the info 🙏

  • fsmeier
    fsmeier Senior Software Engineer & Developer Enablement Advocate Sprykee Posts: 1,005 ⚖️ - Guardians (admin)
    edited June 2023