Calling Developers!
We are reenergizing our code contribution process! Learn More

What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

true, but if you want to run it as a pre-commit hook you want to run it on all

Options
UKGT7RC7P
UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
edited March 2020 in Slack General

true, but if you want to run it as a pre-commit hook you want to run it on all

Comments

  • UKHD8KTMF
    UKHD8KTMF Posts: 393 🧑🏻‍🚀 - Cadet
    Options

    personally I am not a great fan of precommit hooks

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    Options

    me neither but I still run this manually before pushing 🙂

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    Options

    better than the build failing 20 minutes later

  • UKHD8KTMF
    UKHD8KTMF Posts: 393 🧑🏻‍🚀 - Cadet
    Options

    well if pipeline takes 20 minutes to fails on code sniffers then I agree ...

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    edited March 2020
    Options

    you can't always help your build env 😞

  • UKHD8KTMF
    UKHD8KTMF Posts: 393 🧑🏻‍🚀 - Cadet
    Options

    but maybe I made a simple change and you do not want to run it

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    Options

    agree, but then it's even more annoying when you realise there should have been some extra whitespace in the simple change 😛

  • UKHD8KTMF
    UKHD8KTMF Posts: 393 🧑🏻‍🚀 - Cadet
    Options

    well, with little discipline it is not a big deal - it is a simple as clicking the right click and running it on a file you are editing

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    Options

    all I'm saying is that instead of that you just composer phpcs before pushing

  • UKHD8KTMF
    UKHD8KTMF Posts: 393 🧑🏻‍🚀 - Cadet
    edited March 2020
    Options

    maybe you can do that in vim, a plugin that will run it for that file that you are editing

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    Options

    yeah, I already have this

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    Options

    ...

  • UKHD8KTMF
    UKHD8KTMF Posts: 393 🧑🏻‍🚀 - Cadet
    Options

    that is by far the fastest option

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    Options

    ok, but in anycase:

    Time: 1.07 secs; Memory: 65.44MB
    

    with 2,788 files

  • UKGT7RC7P
    UKGT7RC7P Posts: 538 🧑🏻‍🚀 - Cadet
    Options

    the Spryker wrapper will take 100x longer because it has no --cache flag (and why wrap it anyway?)

  • UKHD8KTMF
    UKHD8KTMF Posts: 393 🧑🏻‍🚀 - Cadet
    Options

    cool, but that is for the second run. First run is faster because of parallel

  • UKTSRTD5M
    UKTSRTD5M Posts: 77 🧑🏻‍🚀 - Cadet
    Options

    nice input and discussion, thanks. For us it's 60min + for travis to fail 😶