Calling Developers!
We are reenergizing our code contribution process! Learn More

What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

Hello o/, we updated our dependencies. one of the dependency that has been updated was `spryker/disc

Options
U01FKQ0S909
U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet

Hello o/,
we updated our dependencies.
one of the dependency that has been updated was
spryker/discount from 9.11.0 to 9.11.3

Version 9.11.3 updated the dependency @spryker/jquery-query-builder from ~2.5.2" to ~2.5.2-spryker.1 [1]

Spryker/jquery-query-builder requires jQuery.extendext [2] but does not contain this dependency in the package.json [3], like in the original package.json [4].

due to this missing dependency our deployment is faulty and our zed ui backoffice is without any asset.

can someone help? what migration steps are needed to be done or can we create an bug ticket $somewhere?

thanks in advance :)

[1] https://github.com/spryker/discount/compare/9.11.2...9.11.3
[2] https://github.com/spryker/jquery-query-builder/blob/2.5.2-spryker.1/README.md
[3] https://github.com/spryker/jquery-query-builder/blob/2.5.2-spryker.1/package.json
[4] https://github.com/mistic100/jQuery-QueryBuilder/blob/2.5.2/package.json#L15

Comments

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    Options

    did u run frontend project install dependencies vor frontend build?

  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    Options

    @UL65CH0MC yes we did 🙂

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    Options

    • vendor/bin/console frontend:project:install-dependencies
    • vendor/bin/console frontend:zed:install-dependencies
    • vendor/bin/console frontend:zed:build -e

  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    Options

    attached the output of the 3 commands, called directly in your given order 🙂

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    Options

    Ok. Did u already checked the group release of this update? Maybe as u said u need to add this dep in package json.
    U have to check che package json of discount bundle. Maybe is there smth missing or they need smth not required in own package json

    Unfortunately I have now not the code to see

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    It seems there is nothing useful - https://api.release.spryker.com/release-group/3280.

  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    edited March 2021
    Options

    we are using the php dependency spryker-feature/promotions-discounts in version 202009.0 [1].
    one of the dependencies is spryker/discount: ^9.10.0

    because of:
    • caret version of this module spryker/discount [2]
    • the patch level update of spryker/discount
    everything should work like a charm?


    thanks @valerii.trots for the link. I did not know this page

    [1] https://packagist.org/packages/spryker-feature/promotions-discounts
    [2] https://getcomposer.org/doc/articles/versions.md#caret-version-range-

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    Options

    do u use docker right? node_modules are not synced between host and container.. this can be probably one problem that u have... even if i mean only node_modules on root level is not synced..

  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    Options

    yes, we (my coworkers and me) all do use docker.

    I called the commands in the docker container (via docker/sdk cli first). so there should be no sync needed and thus no sync problem, I guess.

    the problem with the missing dependency occures on multiple OSs.
    • MacOS with Mutagen
    • Linux (I think mainly ubuntu, but i am not sure)
    • and also in our CI/CD with Debian (I am not 100% sure about Debian…)

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    Options

    ok. i will take a look what version we use.. i ll come back to u..

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    There are no problems at our CI, so I don't have anything to say. Except let's ask @UN6T8SEM7 or @UQRP02SP2 to take a look here.

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    Options

    We use spryker/discount:9.11.3 too and we don't have this problem.
    Can u please attach your package.json?

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    edited March 2021
    Options

    Dependencies
    • jQuery >= 1.10
    • Bootstrap >= 3.1 (CSS only)
    jQuery.extendext
    doT.js (@master until the author decide to publish a new version)
    MomentJS (optional, for Date/Time validation)
    • Other Bootstrap/jQuery plugins used by plugins
    ($.extendext and doT.js are directly included in the standalone file)

    (from documentation copy & pasted). it means that u dont need any extra requirement.. it shoudl already be there in jquery-builder

  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    Options

    that is what I tried to say in my initial message: I think the dependency is missing in the package.json, if you compare the original package.json from mistic100 and spryker
    or we do need to add the dependency manually to our project?
    but I think its a bug in the spryker/jquery-query-builder
    😅

    [3] <https://github.com/spryker/jquery-query-builder/blob/2.5.2-spryker.1/package.json>
    [4] <https://github.com/mistic100/jQuery-QueryBuilder/blob/2.5.2/package.json#L15>
    
  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    Options

    (@UL65CH0MC the standalone file you are linking is a built file, based on a package.json that contains the jquery-jquery-builder dependency. when building assets npm tries to (recursively) install all dependencies and build its own and doesn’t use any dist files)

  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    Options

    sorry, I did not see your request for the package.json.
    here it is (attached)

    I thought the package.json should be independent to the zed modules and the zed modules define their own dependencies. 🤔

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ Löffelhardt Spryker Solution Partner Posts: 871 🧑🏻‍🚀 - Cadet
    Options

    @U01FKQ0S909
    I have the same problem for an installation of a legacy spryker project..
    Product-Relation and Discount Zed Bundle failed to build ZED Frontend.

    The problem seems to be jquery-query-builder and sql-parser dependencies (git spryker deps) that npm install just not install (why!?? it is a myster).

    @valerii.trots maybe some frontend dev can be helpful here to understand why it s happend this..

  • Aleksander Kovalenko
    Aleksander Kovalenko Sprykee Posts: 45 🧑🏻‍🚀 - Cadet
    Options

    Just checked, you are totally right - some dependencies are missed. We gonna fix it soon. Thanks for pointing into this issue.

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    Would be nice if you could create a support case so we won't forget to notify you once it's fixed in case you need it.

  • U01LKKBK97T
    U01LKKBK97T Posts: 287 🧑🏻‍🚀 - Cadet
    Options

    Has this been solved already?
    Still getting this when using spryker/discount 9.17.0:

    ERROR in ./vendor/spryker/discount/assets/Zed/node_modules/@spryker/jquery-query-builder/index.js
    Module not found: Error: Can't resolve 'jquery-extendext' in '/data/vendor/spryker/discount/assets/Zed/node_modules/@spryker/jquery-query-builder'
     @ ./vendor/spryker/discount/assets/Zed/node_modules/@spryker/jquery-query-builder/index.js 5:0-27
     @ ./vendor/spryker/discount/assets/Zed/js/modules/libs/spryker-query-builder.js
     @ ./vendor/spryker/discount/assets/Zed/js/modules/libs/sql-factory.js
     @ ./vendor/spryker/discount/assets/Zed/js/modules/main.js
     @ ./vendor/spryker/discount/assets/Zed/js/spryker-zed-discount-main.entry.js
    ✘ build failed
    
  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    Options

    Hi @U01LKKBK97T,
    looks like this is not solved yet.

    hi @valerii.trots, @UN6T8SEM7,
    I don’t know how to create a support case.

  • U01FKQ0S909
    U01FKQ0S909 Posts: 20 🧑🏻‍🚀 - Cadet
    edited September 2021
    Options

    I think a fix should be pretty simple 😕
    re-add the dependencies in the package.json here:
    https://github.com/spryker/jquery-query-builder/blob/master/package.json
    copied from here:
    https://github.com/mistic100/jQuery-QueryBuilder/blob/dev/package.json

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    Options

    There is an open PR to fix this issue. Unfortunately though I don't have any ETA for you here.