Calling Developers!
We are reenergizing our code contribution process! Learn More

What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

Can someone explain the `BridgeConstructorArgumentTypehintsRule` (`\ArchitectureSniffer\Zed\Dependen

Options
UKHR9UN00
UKHR9UN00 Posts: 70 🧑🏻‍🚀 - Cadet
edited July 2019 in Help

Can someone explain the BridgeConstructorArgumentTypehintsRule (\ArchitectureSniffer\Zed\Dependency\Bridge\BridgeConstructorArgumentTypehintsRule)?
By that rule, it's not legit to typehint the given parameter. As the bridge is an implementation, I think we should be allowed to expect a certain type of argument.
How else should we make sure, we map the right methods?

Comments

  • Andriy Netseplyayev
    Andriy Netseplyayev Domain Lead Solution Architecture Sprykee Posts: 519 🧑🏻‍🚀 - Cadet
    Options

    Hey Felix, “Bridge” is invented for Spryker core in order to loose the coupling between different modules. That’s why you see in almost every bridge f.e.


    it helps you still to have an IDE autocompletion for dev needs, but doesn’t create a direct dependency between modules.

  • Andriy Netseplyayev
    Andriy Netseplyayev Domain Lead Solution Architecture Sprykee Posts: 519 🧑🏻‍🚀 - Cadet
    edited July 2019
    Options

    The question I would ask is rather why do you have a problem with this rule first of all? Are you extending or introducing the bridge on project level?

  • Andriy Netseplyayev
    Andriy Netseplyayev Domain Lead Solution Architecture Sprykee Posts: 519 🧑🏻‍🚀 - Cadet
    Options
  • UKHR9UN00
    UKHR9UN00 Posts: 70 🧑🏻‍🚀 - Cadet
    edited July 2019
    Options

    Hi Andriy,
    thanks for your reply. You're absolutely right about not to use Bridges on project level. We're probably doing it wrong in this particular case, where it came up.

  • Andriy Netseplyayev
    Andriy Netseplyayev Domain Lead Solution Architecture Sprykee Posts: 519 🧑🏻‍🚀 - Cadet
    Options

    no worries, that’s usually a first intention on the project. But since you know now - spread the knowledge 😄